Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scope filter may be broken (KeyError on pk) #548

Closed
mxsasha opened this issue Sep 4, 2021 · 0 comments · Fixed by #549
Closed

Scope filter may be broken (KeyError on pk) #548

mxsasha opened this issue Sep 4, 2021 · 0 comments · Fixed by #549
Assignees
Labels
bug Something isn't working release blocker blocks the next release
Milestone

Comments

@mxsasha
Copy link
Collaborator

mxsasha commented Sep 4, 2021

Logs from an instance on current main:

2021-09-04 13:54:07,369 irrd[1312245]: [irrd.mirroring.mirror_runners_import#ERROR] An exception occurred while attempting a scopefilter status update: 'pk'
Traceback (most recent call last):
  File "/home/irrd/irrd/irrd/mirroring/mirror_runners_import.py", line 311, in run
    status = validator.validate_all_rpsl_objects(self.database_handler)
  File "/home/irrd/irrd/irrd/scopefilter/validators.py", line 141, in validate_all_rpsl_objects
    pks_to_enrich = [obj['pk'] for objs in objs_changed.values() for obj in objs]
  File "/home/irrd/irrd/irrd/scopefilter/validators.py", line 141, in <listcomp>
    pks_to_enrich = [obj['pk'] for objs in objs_changed.values() for obj in objs]
KeyError: 'pk'

Definite new bug in scope filter introduced in #530 because we don't retrieve that column which has not been noticed by the tests. Might be a case of #329. Does not affect 4.1.

@mxsasha mxsasha added bug Something isn't working release blocker blocks the next release labels Sep 4, 2021
@mxsasha mxsasha added this to the Release 4.2 milestone Sep 4, 2021
@mxsasha mxsasha self-assigned this Sep 4, 2021
@mxsasha mxsasha linked a pull request Sep 4, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working release blocker blocks the next release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant