Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete doing strict checking when not required #647

Closed
rubenskuhl opened this issue May 8, 2022 · 4 comments · Fixed by #912
Closed

delete doing strict checking when not required #647

rubenskuhl opened this issue May 8, 2022 · 4 comments · Fixed by #912
Assignees
Labels
bug Something isn't working

Comments

@rubenskuhl
Copy link

Is your feature request related to a problem? Please describe.
In order to delete objects, IRRd is checking whether the fields in the object have proper syntax. But legacy objects might not have, due to not following current syntax requirements.

Describe the solution you'd like
On objects that are being deleted, only the primary key components should be checked. On a route(6) it's both prefix and origin, on aut-num is the AS.

Describe alternatives you've considered
An alternative would to be remove those objects from the output prior to sending it to IRRd for deletion.

Additional context
One such use was to refer whom to notify by handle instead of by email, but this can manifest at almost any field.

@mxsasha mxsasha self-assigned this Jun 20, 2022
@mxsasha mxsasha added the bug Something isn't working label Jun 20, 2022
@mxsasha mxsasha added this to the Release 4.3 milestone Jun 20, 2022
@mxsasha
Copy link
Collaborator

mxsasha commented Jun 20, 2022

I agree. There is some support in the RPSL parser already, we use it for NRTM deletes which sometimes have incomplete objects.

@mxsasha
Copy link
Collaborator

mxsasha commented Jan 18, 2023

This is more complicated than I thought, in part because the tests for this are kind of hairy. Will revisit with #412.

@mxsasha mxsasha removed this from the Release 4.3 milestone Jan 18, 2023
@mxsasha
Copy link
Collaborator

mxsasha commented Jan 18, 2023

As you say, the workaround for now is to fix the object when submitting it for deletion - it does not need to match the existing object outside of the primary key, object class and source.

@schelcj
Copy link
Contributor

schelcj commented Nov 14, 2023

This is proving to be a problem for us as well. Has there been any development on this recently?

mxsasha added a commit that referenced this issue Feb 23, 2024
When an object is deleted, the submitted object's values are
ignored except for the primary key. Therefore, there's no
need to validate them in strict mode.
This also disables the rules validator for deletion objects, re #909
@mxsasha mxsasha linked a pull request Feb 23, 2024 that will close this issue
mxsasha added a commit that referenced this issue Feb 26, 2024
When an object is deleted, the submitted object's values are
ignored except for the primary key. Therefore, there's no
need to validate them in strict mode.
This also disables the rules validator for deletion objects, re #909
mxsasha added a commit that referenced this issue Feb 26, 2024
When an object is deleted, the submitted object's values are
ignored except for the primary key. Therefore, there's no
need to validate them in strict mode.
This also disables the rules validator for deletion objects, re #909
mergify bot pushed a commit that referenced this issue Feb 26, 2024
When an object is deleted, the submitted object's values are
ignored except for the primary key. Therefore, there's no
need to validate them in strict mode.
This also disables the rules validator for deletion objects, re #909

(cherry picked from commit 3239354)

# Conflicts:
#	irrd/updates/parser.py
mxsasha pushed a commit that referenced this issue Feb 26, 2024
…ackport #912) (#913)

When an object is deleted, the submitted object's values are
ignored except for the primary key. Therefore, there's no
need to validate them in strict mode.
This also disables the rules validator for deletion objects, re #909

(cherry picked from commit 3239354)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants