Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

type hints #510

Open
antonkulaga opened this issue Dec 20, 2024 · 2 comments
Open

type hints #510

antonkulaga opened this issue Dec 20, 2024 · 2 comments

Comments

@antonkulaga
Copy link

It is a huge pain to read eliot sources as no type hints are provided. Can you please add typehints?
@itamarst
Copy link
Owner

Types would definitely be nice! Unfortunately I don't really have a lot of time for maintenance at the moment. Would you be interested in providing a PR for the core subset of the API?

@antonkulaga
Copy link
Author

I can. If we manage to fix json serialization (that is the main issue that makes eliot almost unusable for my team) I am ready to contribute on other aspects. Also, you probably should drop python 3.8 as it has many issues with type hints

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@antonkulaga @itamarst