Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto format repo code #246

Open
Naton1 opened this issue Dec 13, 2024 · 0 comments
Open

Auto format repo code #246

Naton1 opened this issue Dec 13, 2024 · 0 comments

Comments

@Naton1
Copy link
Contributor

Naton1 commented Dec 13, 2024

The code here has clearly been worked on by numerous people over several years, and the current code formatting shows that (it's a bit inconsistent in many places).

It'd be nice if the code formatting here was enforced via some formatter like spotless so that it's easier to read, and cleaner. Personally I like palantir's java format.

I'm happy to make this change but wanted to bring it up first before doing it.

This is really easy to do with gradle, like:

plugins {
    ... existing plugins
    id("com.diffplug.spotless") version "6.25.0"
}

...

spotless {
    java {
        palantirJavaFormat()
    }
}

// optional, to format on every build:
tasks.named("spotlessCheck") {
    dependsOn("spotlessApply")
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant