-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Could a --routes-refresh parameter be implemented? #271
Comments
That's a great idea! |
@Codrax with this library it looks like I could have it watch for file changes. Would that be even better or still prefer/recommend a timer based approach? |
Both cases would be great as long as the file reloads. I don't know a lot about that library, but I'm pretty sure the timer based approach is simpler as that just utilises the CPUs task scheduler, which I think is more optimised. But both options are valid. |
at lest for the fsnotify backend for linux the CPU over head is very little |
Right. It's driven by existing filesystem OS events, so there's virtually no extra overhead. |
I would like to run around 10 servers simultaneously, and currently, to add/remove a server I need to change the
config.json
. And the proxy need to be closed and re-opened to index the changes.With a
--routes-refresh
parameter, optionally taking a second input for how often to refresh the routes, the application could compare the last stored modification date of the file provided with--routes-config
.This would allow the server list to be updated gracefully without restarting all servers.
Thank you!
The text was updated successfully, but these errors were encountered: