Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UI to use new endpoint to get a list of operations #492

Open
guo0693 opened this issue Dec 2, 2019 · 5 comments
Open

Update UI to use new endpoint to get a list of operations #492

guo0693 opened this issue Dec 2, 2019 · 5 comments
Labels
changelog:dependencies Update to dependencies

Comments

@guo0693
Copy link

guo0693 commented Dec 2, 2019

Requirement - what kind of business use case are you trying to solve?

Relates to jaegertracing/jaeger#1920

Problem - what in Jaeger blocks you from solving the requirement?

Currently UI is using the old endpoint to get a list of operation names:

api/services/%s/operations

With the change in #1920, the new endpoint:

api/operations?service=%s&spanKind=%s

can return a list of operation names with spanKind.

Proposal - what do you suggest to solve the problem or improve the existing situation?

Please use the new endpoint to retrieve the list of operation names together with spanKind. And also render & order the dropdown list with special tags, e.g. (server) before the operation name.

Any open questions to address

How do we define the order of dropdown list?

@guo0693
Copy link
Author

guo0693 commented Dec 2, 2019

@everett980 @yurishkuro

@everett980
Copy link
Collaborator

everett980 commented Dec 6, 2019

@guo0693 is this change for the search view as well as the DDG operation drop down?
The DDG is already updated, but I don't think search view should only show server operations. If I'm a service owner I may want to see traces that hit a particular client span of mine (such as if I wrapped deprecated code in a client span).

@guo0693
Copy link
Author

guo0693 commented Dec 6, 2019

@yurishkuro proposed the UI enhancement of showing (spanKind) in the dropdown. I don't think we want to filter out the operations in the search page, we probably just need to show the prefix. We do need to figure out how to order the operations though.

The main point of this issue is to use the new endpoint so that backend can remove the legacy one in future release.

@everett980
Copy link
Collaborator

Oh so this is to use the new endpoint without any query param filter?

@yurishkuro
Copy link
Member

There are two asks. One is to switch to the new endpoint that does not encode service name in the path. It returns the result a bit differently, with span kinds. Second ask is to display span kinds in the Services drop down, and order services by (kind, name), but with kind=server coming above kind=client and others (in other words, “endpoints” first).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:dependencies Update to dependencies
Projects
None yet
Development

No branches or pull requests

4 participants