Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Classes in signaturetest module needed in test archive are not public #1365

Closed
starksm64 opened this issue Jul 15, 2024 · 2 comments · Fixed by #1367
Closed

Classes in signaturetest module needed in test archive are not public #1365

starksm64 opened this issue Jul 15, 2024 · 2 comments · Fixed by #1367
Assignees
@scottmarlow

Comments

@starksm64
Copy link
Contributor

Describe the bug
While testing the signaturetest module porting, I ran across the following three classes that need to be placed into the test archive, that are not public:

            com.sun.ts.tests.signaturetest.PackageList.class,
            com.sun.ts.tests.signaturetest.SignatureTestDriver.SignatureFileInfo.class,
            com.sun.ts.tests.signaturetest.javaee.JavaEESigTest.Containers.class,

Expected behavior
These need to be public in order to be visible to the StrinkWrap layer that builds the test archive.
starksm64 added a commit to jakartaredhat/platform-tck-refactor that referenced this issue Jul 15, 2024
@starksm64
Make the sigtest classs public for use in the arquillian test artifacts
7b07269 
Fixes jakartaee#1365
Add back the setup(String[], Properties) method and have setup() delegate to it.
Improves jakartaee#1366

Signed-off-by: Scott M Stark <[email protected]>
@starksm64 starksm64 mentioned this issue Jul 15, 2024
Merged
starksm64 added a commit that referenced this issue Jul 15, 2024
@starksm64
Make the sigtest classs public for use in the arquillian test artifac…
a8575c7 
…ts (#1367)

Fixes #1365
Add back the setup(String[], Properties) method and have setup() delegate to it.
Improves #1366

Signed-off-by: Scott M Stark <[email protected]>
@edburns
Copy link
Contributor

edburns commented Jul 15, 2024

Hello @starksm64, can you please point to an existing commit that shows something similar to this?

@starksm64
Copy link
Contributor Author

The changes on #1367 show the changes

@starksm64 starksm64 linked a pull request Jul 24, 2024 that will close this issue
Make the sigtest classs public for use in the arquillian test artifacts #1367
Merged
@github-project-automation github-project-automation bot moved this from Ready to Assign to Done in Jakarta EE11 TCK Release Jul 24, 2024
@scottmarlow scottmarlow self-assigned this Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scottmarlow scottmarlow

Labels
None yet
Projects
Jakarta EE11 TCK Release
Status: Done
Milestone
No milestone
3 participants
@edburns @starksm64 @scottmarlow