Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding examples to each note #6

Open
TerryGeng opened this issue Mar 27, 2021 · 1 comment
Open

Adding examples to each note #6

TerryGeng opened this issue Mar 27, 2021 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@TerryGeng
Copy link

TerryGeng commented Mar 27, 2021

My personal learning habit is memorizing words with examples. I'd appreciate if example sentences could be added to the decks in this repo.

Currently, I have tried to add some examples to words of my interest manually and created a new field called examples, added a new div into the back template

<div class="expression">
  {{expression}}
</div>

and adjust the style

.examples {
  text-align: left;
  padding: 30px;
  font-size: 20px;
}

I understand that manually adding examples is not a feasible task. I have checked several public dictionary services, but sadly few of them provide APIs. Capturing the webpage seems to be the only way. But nonetheless, here are some possible options:

Of course, at the end of the day, some manual reviews are needed and, in some complicated cases, choices have to be made.

I'm just wondering if anyone is interested in this idea and are there any suggestions?

@jamsinclair
Copy link
Owner

Apologies for the late reply @TerryGeng.

Yes I had thought of this. Some of the decks I looked at sourcing pulled examples straight from jisho and tatoeba sources. The issue I saw was often the examples weren't great for learning and active recall.

some manual reviews are needed and, in some complicated cases, choices have to be made.

Yes that's inevitable. To have a great deck with examples would require a lot of curation and moderation. I would also see a benefit to having consistency among examples throughout the deck too. For those reasons, I didn't implement it.

I can automate fetching from those sites. If yourself or others would like to help curate the examples, I'd be happy to start on the feature.

@jamsinclair jamsinclair added enhancement New feature or request help wanted Extra attention is needed labels Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants