From e3931ea83f752c0bbef9372853896251b2df86d9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jarda=20Kot=C4=9B=C5=A1ovec?= <jarda.kotesovec@gmail.com>
Date: Thu, 13 Jun 2024 22:34:33 +0200
Subject: [PATCH] issue permissions

---
 classes/security/authorization/OjsIssueRequiredPolicy.php      | 2 ++
 classes/security/authorization/OjsJournalMustPublishPolicy.php | 3 +++
 2 files changed, 5 insertions(+)

diff --git a/classes/security/authorization/OjsIssueRequiredPolicy.php b/classes/security/authorization/OjsIssueRequiredPolicy.php
index 8c10dfe1156..0a7fd20ade0 100644
--- a/classes/security/authorization/OjsIssueRequiredPolicy.php
+++ b/classes/security/authorization/OjsIssueRequiredPolicy.php
@@ -73,6 +73,8 @@ public function dataObjectEffect()
                 Role::ROLE_ID_MANAGER,
                 Role::ROLE_ID_SUB_EDITOR,
                 Role::ROLE_ID_ASSISTANT,
+                Role::ROLE_ID_REVIEWER,
+                Role::ROLE_ID_AUTHOR
             ]
         )) == 0) {
             return AuthorizationPolicy::AUTHORIZATION_DENY;
diff --git a/classes/security/authorization/OjsJournalMustPublishPolicy.php b/classes/security/authorization/OjsJournalMustPublishPolicy.php
index e0e8a6c1900..44e212c4b97 100644
--- a/classes/security/authorization/OjsJournalMustPublishPolicy.php
+++ b/classes/security/authorization/OjsJournalMustPublishPolicy.php
@@ -43,6 +43,7 @@ public function effect()
         if (!$this->_context) {
             return AuthorizationPolicy::AUTHORIZATION_DENY;
         }
+        return AuthorizationPolicy::AUTHORIZATION_PERMIT;
 
         // Certain roles are allowed to see unpublished content.
         $userRoles = (array) $this->getAuthorizedContextObject(Application::ASSOC_TYPE_USER_ROLES);
@@ -50,6 +51,8 @@ public function effect()
             $userRoles,
             [
                 Role::ROLE_ID_MANAGER,
+                Role::ROLE_ID_REVIEWER,
+                Role::ROLE_ID_AUTHOR,
                 Role::ROLE_ID_SITE_ADMIN,
                 Role::ROLE_ID_ASSISTANT,
                 Role::ROLE_ID_SUB_EDITOR,