Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: replace javascript with clojurescript #3

Open
avelino opened this issue Dec 18, 2024 · 6 comments · May be fixed by #5
Open

proposal: replace javascript with clojurescript #3

avelino opened this issue Dec 18, 2024 · 6 comments · May be fixed by #5

Comments

@avelino
Copy link
Contributor

avelino commented Dec 18, 2024

What do you think about changing the implementation of this plugin to ClojureScript?
I know that logseq plugins are written in JavaScript, but it's possible to write plugins using ClojureScript and make the plugin code closer to logseq's code (which is written in Clojure)

Here's an example of a plugin that I maintain written in ClojureScript
https://github.com/avelino/logseq-summarize

feel free to disagree, I'm just sharing what I prefer :D

@jarodise
Copy link
Owner

hi, thanks for the suggestion, to be completely honest, I know nothing about coding, the plugin was written 100% by AI(windsurf), I am not sure I am capable of handle such a major overhaul.

@avelino
Copy link
Contributor Author

avelino commented Jan 2, 2025

I will work on a version written in Clojure, so you can look at it and see which one is easier to maintain.

I am willing to help with logseq-copilot regardless of whether it's in Clojure or JavaScript.

@avelino
Copy link
Contributor Author

avelino commented Jan 3, 2025

bringing news 🎉

I made the first version of logseq-copilot in ClojureScript
here you can check the code and evaluate if it's "understandable" (readable) and simple to maintain

to test you can download the package here

@jarodise comment what you think, remembering that I am willing to help maintain

@avelino
Copy link
Contributor Author

avelino commented Jan 6, 2025

@jarodise if it makes sense I'll finish the implementation and send PR with the code

@jarodise
Copy link
Owner

Hi, sorry for the late reply, I just tested the package you provided, somehow with the Gemini API, I can never get it to work, it always shows the 404 error, I reverted back to the original plugin, everything worked with the exact same settings, don't know why it happened. Have you tried this plugin with Gemini API?

@avelino
Copy link
Contributor Author

avelino commented Jan 10, 2025

Have you tried this plugin with Gemini API?

I haven't tested it yet, I sent it for you to look at the code base and see if it's understandable for you who is not a developer (you mentioned that you made the current plugin using llm).

If it's understandable and you agree to keep the Clojure version as the main one, I'll complete the entire implementation (leaving everything 100% working as your version is).

Shall we proceed with my proposal to replace your JavaScript version with the Clojure version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants