Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding typings to codebase #16

Open
faradayyg opened this issue Jul 25, 2023 · 6 comments
Open

Adding typings to codebase #16

faradayyg opened this issue Jul 25, 2023 · 6 comments

Comments

@faradayyg
Copy link
Contributor

I am using this issue as a discussion board sort of.

Since the change in #15 updated the required python version to 3.8 and updated the minimum Django version to 3.2, I would like to add typings to the entire codebase.

As we all know, there are many advantages to typing, most importantly is that it eliminates an entire class of errors.

Let me know if anyone has objections to this. Else, I'd like to get started on this.

As a follow up, we could add some type checkers such as Mypy to the codebase. I of course would be willing to do this as well.

@frgmt
Copy link
Collaborator

frgmt commented Jul 26, 2023

@faradayyg Thank you. I don't think anyone would disagree. I'd like to appreciate you for working on it.

@faradayyg
Copy link
Contributor Author

Cool! Keeping this issue open as a kind of TODO Item. Will close as soon as I have a PR that is accepted.

Thanks for your quick responses @frgmt

@kevalrajpalknight
Copy link

Hi @faradayyg

I hope you're doing well! 👋 I noticed that the typing issue #15 has been open for about 6 months now, and I'm eager to contribute to the project. I see that adding typings and type checkers like Mypy would be beneficial for the codebase.

If you haven't had the chance to start working on this, I'd be happy to take it up. Let me know if it's okay with you, and I'll get started on preparing a PR. If there's anything specific you'd like me to focus on or if you have any guidance, please feel free to share.

Looking forward to contributing to the project!

@faradayyg
Copy link
Contributor Author

Hello @kevalrajpalknight I kind of got stuck at some point and got busy with other things, I'd be glad if you could take this on, and will be available to provide all the support you need.

I have not really done anything on this yet, so you can start afresh with this.

Many thanks and looking forward to collaborating on this.

@kevalrajpalknight
Copy link

Alright, thanks for the update @faradayyg I will start working on this, I will be happy if we can work on this together. That would help to achieve the goal more quickly.

@JohananOppongAmoateng
Copy link

Hey @kevalrajpalknight are you still actively working on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants