Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR(#272) Replaces code for PR (#275) #286

Closed
brukberhane opened this issue Oct 18, 2022 · 1 comment
Closed

PR(#272) Replaces code for PR (#275) #286

brukberhane opened this issue Oct 18, 2022 · 1 comment

Comments

@brukberhane
Copy link
Contributor

As stated in the title, the PR that was most recently merged into the develop branch (#272) that adds the option for token prefixes undoes some of the work done in PR #275. Namely in the model.py file, the AuthTokenManager class lost it's **kwargs parameters so that you can't really populate any custom values to the AuthToken custom class you create...
@brukberhane brukberhane mentioned this issue Oct 18, 2022
Merged
@johnraz
Copy link
Collaborator

johnraz commented Jun 17, 2024

Corresponding MR #287 has been merged, thanks for the fix and sorry for the long delay.

@johnraz johnraz closed this as completed Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@johnraz @brukberhane