benchmark should use monotonic time #1253
codefromthecrypt
started this conversation in
General
Replies: 1 comment 1 reply
-
Done, thanks! But fo WASI, it doesn't make a difference. |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
I think this doesn't really need the discussion first, but just in case:
now()
in benchmarks compiles to wasm that uses the real time clock, not the monotonic one.libsodium/test/default/cmptest.h
Line 119 in 6d56607
I think it should be something like
clock_gettime(CLOCK_MONOTONIC, &ts)
instead, to ensure better accuracy.Beta Was this translation helpful? Give feedback.
All reactions