Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Release Drafter usage on backport branches #14

Open
jglick opened this issue Mar 1, 2021 · 4 comments
Open

Test Release Drafter usage on backport branches #14

jglick opened this issue Mar 1, 2021 · 4 comments

Comments

@jglick
Copy link
Collaborator

jglick commented Mar 1, 2021

Currently the action assumes that there is a next pseudo-version for Release Drafter. This system likely does not make much sense when backport branches are involved. Should the action detect that it is running on a nondefault branch and just skip the usage of Release Drafter?

@jetersen
Copy link
Collaborator

it could assume some things if workflow is not run on main and is manual?
So could the shell script, it could use a shared input to target that draft next-branchThatIsNotMain

@jglick
Copy link
Collaborator Author

jglick commented Jul 22, 2022

Or rather than next, just name the draft release according to the base branch, like master or 123.x.

@jglick jglick transferred this issue from jenkins-infra/jenkins-maven-cd-action Jul 25, 2022
@jglick
Copy link
Collaborator Author

jglick commented Jul 25, 2022

Does not seem to run automatically: unexpected commit from verify-ci-status-action.

Running manually on the backport branch seems to work, including picking the correct PRs for R.D.: https://github.com/jenkinsci/ssh-credentials-plugin/releases/tag/277.280.v1e86b_7d0056b_

It does use the next release name, though only temporarily, so this seems like a race condition (do not try to cut releases from both trunk and a backport branch around the same time).

@jetersen
Copy link
Collaborator

It does use the next release name, though only temporarily, so this seems like a race condition (do not try to cut releases from both trunk and a backport branch around the same time).

This seems reasonable, otherwise your asking for trouble? 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants