Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AKZ AZBLOB Issues in jx-requirements.yml EnsureBucketIsCreated not implemented for LegacyBucketProvider #6837

Closed
michaeljohnbennett opened this issue Feb 27, 2020 · 7 comments
Labels
area/aks kind/bug Issue is a bug lifecycle/rotten priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@michaeljohnbennett
Copy link

@chrismellard BTW we're in the process of moving to jx boot as our strategic way to install/configure/upgrade/edit Jenkins X installation, storage, networking, ingress/TLS/DNS and whatnot so if you're interested in getting storage/vault working for AKS I'd maybe start there.

with boot you can specify the URLs of the storage locations for logs in your jx-requirements.yml. I've just polished the docs around that here: https://jenkins-x.io/getting-started/boot/#storage

I think if you specify the azblob://mybucket URLs for logs in your jx-requirements.yml file it might actually work on AKS :)

But it would be nice to add an AKS implementation of this interface:

return storage.NewGKEBucketProvider(requirements)
so that we can lazily create AKS buckets and verify they exist etc Usually if the user enables long term storage on GKE we let folks enter a bucket name to create and if not lazily create one etc. Would be nice to have a similar UX on AKS toto.

Originally posted by @jstrachan in #703 (comment)

I can't see this working in 2.0.1212.

When we get to verify we get this error:

Verifying Storage...
error: failed to ensure the bucket URL azblob://xxx.blob.core.windows.net/logs is created: EnsureBucketIsCreated not implemented for LegacyBucketProvider
error: failed to interpret pipeline file jenkins-x.yml: failed to run '/bin/sh -c jx step verify preinstall --provider-values-dir="kubeProviders"' command in directory '.', output: ''
Verifying the CLI packages using version stream URL: https://github.com/jenkins-x/jenkins-x-versions.git and git ref: v1.0.362
using version 2.0.1212 of jx
CLI packages kubectl, git, helm seem to be setup correctly
NAME               VERSION
jx                 2.0.1212
Kubernetes cluster v1.15.7
kubectl            v1.16.3
helm client        v2.16.3+g1ee0254
git                2.21.0 (Apple Git-120)

This happens when running jx boot

@michaeljohnbennett
Copy link
Author

We have disable devops in the requirements and the storage part looks like this:

storage:
  backup:
    enabled: true
    url: azblob://xxx.blob.core.windows.net/backup/
  logs:
    enabled: true
    url: azblob://xxx.blob.core.windows.net/logs/
  reports:
    enabled: true
    url: azblob://xxx.blob.core.windows.net/reports/
  repository:
    enabled: true
    url: azblob://xxx.blob.core.windows.net/repistory/
vault: {}

@deanesmith deanesmith added area/aks priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/bug Issue is a bug labels Mar 2, 2020
@jenkins-x-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://jenkins-x.io/community.
/lifecycle stale

@jenkins-x-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Provide feedback via https://jenkins-x.io/community.
/lifecycle rotten

@deanesmith
Copy link
Contributor

Related to #7190

@chrismellard
Copy link

This PR #7451 addresses this issue by implementing the necessary half of the AKSBucketProvider, i.e.EnsureBucketIsCreated

@jenkins-x-bot
Copy link
Contributor

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Provide feedback via https://jenkins-x.io/community.
/close

@jenkins-x-bot
Copy link
Contributor

@jenkins-x-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Provide feedback via https://jenkins-x.io/community.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/aks kind/bug Issue is a bug lifecycle/rotten priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

No branches or pull requests

4 participants