Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate external URLs return 200 #364

Open
janfaracik opened this issue Dec 17, 2024 · 4 comments · May be fixed by #392
Open

Validate external URLs return 200 #364

janfaracik opened this issue Dec 17, 2024 · 4 comments · May be fixed by #392

Comments

@janfaracik
Copy link
Contributor

Fairly common in static sites, e.g. jenkins.io does it:

https://github.com/jenkins-infra/jenkins.io/blob/master/Makefile#L27-L28

I've seen it elsewhere too.

Ideally not something enabled by default as I don't really like tests hitting the network if possibly, maybe it could only run in CI?

Originally posted by @timja in #363 (comment)

@biru-codeastromer
Copy link

biru-codeastromer commented Jan 29, 2025

Hello Sir @janfaracik , can I work on this ? Please let me know . Thanks !

@janfaracik
Copy link
Contributor Author

Hello Sir @janfaracik , can I work on this ? Please let me know . Thanks !

Hey, go for it :)

@biru-codeastromer
Copy link

Hey, go for it :)

Thanks Sir , will be raising a PR soon !

@biru-codeastromer biru-codeastromer linked a pull request Jan 29, 2025 that will close this issue
6 tasks
@biru-codeastromer
Copy link

Hey, go for it :)

Hello Sir, I have raised a PR , please let me know if my approach is proper there #392 .
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants