From aec4f0cd8142bb260579b76f5434fb80278a4e11 Mon Sep 17 00:00:00 2001 From: Jesse Glick Date: Thu, 19 Jan 2023 17:28:30 -0500 Subject: [PATCH] Trying against to make `KubernetesSamples` optional --- .../kubernetes/pipeline/KubernetesSamples.java | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/main/java/org/csanchez/jenkins/plugins/kubernetes/pipeline/KubernetesSamples.java b/src/main/java/org/csanchez/jenkins/plugins/kubernetes/pipeline/KubernetesSamples.java index 4d00e1ffd3..524bf9333f 100644 --- a/src/main/java/org/csanchez/jenkins/plugins/kubernetes/pipeline/KubernetesSamples.java +++ b/src/main/java/org/csanchez/jenkins/plugins/kubernetes/pipeline/KubernetesSamples.java @@ -16,20 +16,20 @@ package org.csanchez.jenkins.plugins.kubernetes.pipeline; -import hudson.Extension; import hudson.ExtensionComponent; import java.io.IOException; import java.nio.charset.StandardCharsets; import jenkins.ExtensionFilter; import org.apache.commons.io.IOUtils; +import org.jenkinsci.plugins.variant.OptionalExtension; import org.jenkinsci.plugins.workflow.cps.GroovySample; public class KubernetesSamples { - @Extension public static final class SuppressToolBasedSamples extends ExtensionFilter { + @OptionalExtension(requirePlugins = "workflow-cps") public static final class SuppressToolBasedSamples extends ExtensionFilter { @Override public boolean allows(Class type, ExtensionComponent component) { - if (type.getName().equals("org.jenkinsci.plugins.workflow.cps.GroovySample")) { // do not link against GroovySample yet + if (type == GroovySample.class) { switch (((GroovySample) component.getInstance()).name()) { case "github-maven": case "scripted": @@ -55,7 +55,7 @@ private static abstract class Static implements GroovySample { } - @Extension(ordinal = 1500, optional = true) public static final class Declarative extends Static { + @OptionalExtension(requirePlugins = "workflow-cps", ordinal = 1500) public static final class Declarative extends Static { @Override public String name() { return "kubernetes-declarative"; @@ -67,7 +67,7 @@ private static abstract class Static implements GroovySample { } - @Extension(ordinal = 1400, optional = true) public static final class Maven extends Static { + @OptionalExtension(requirePlugins = "workflow-cps", ordinal = 1400) public static final class Maven extends Static { @Override public String name() { return "kubernetes-maven"; @@ -79,7 +79,7 @@ private static abstract class Static implements GroovySample { } - @Extension(ordinal = 1300, optional = true) public static final class Windows extends Static { + @OptionalExtension(requirePlugins = "workflow-cps", ordinal = 1300) public static final class Windows extends Static { @Override public String name() { return "kubernetes-windows";