Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting where to place currency symbol #46

Closed
1412kaito opened this issue Aug 20, 2022 · 3 comments
Closed

Add setting where to place currency symbol #46

1412kaito opened this issue Aug 20, 2022 · 3 comments

Comments

@1412kaito
Copy link

I noticed that while using the USD $ symbol, it is placed before (left side) the numbers. But when I tried selecting a couple other currency symbols - I tried IDR/id (as it's my local currency) and a few of the EUR ones - they are placed behind (right side) the numbers.

Especially for the Euro-symbol ones, there are some that have the symbols on the left side 🤔.

I've taken a look at numbro, but there doesn't seem to be any config about the symbol placement.

Would it be possible to have a setting to allow users to choose where the symbols are placed?

Thanks!

@1412kaito
Copy link
Author

Oh, I just dug a bit deeper and found that in numbro there is in fact a way to specify postfix or prefix.

I'll try to create a issue / PR there to adjust this

@jerameel
Copy link
Owner

For now, it should at least follow the standard format per country/currency. The only config I've modified is the mantissa which is defined to 2. If you feel like the default currency format is wrong, you can submit an issue on numbro instead.

I'm closing this temporarily but happy to reopen this if there's a lot of users that needs this particular issue.

@1412kaito
Copy link
Author

I have opened a PR over in numbro specific for my local currency, but I couldn't really get a solid reference material - at least not online - on where the symbols should be placed for my local currency 🤔

anyway, thanks for the clarification!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants