Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move into core codebase #49

Open
Tyriar opened this issue May 14, 2023 · 3 comments
Open

Move into core codebase #49

Tyriar opened this issue May 14, 2023 · 3 comments

Comments

@Tyriar
Copy link

Tyriar commented May 14, 2023

Finally got around to pulling this into vscode in microsoft/vscode#182442, it works really well 👏

I've made it currently disabled by default and marked a setting with experimental. One of the things that would be great to do before enabling it by default is to merge it into the core codebase so we can strongly type the internal API usage microsoft/vscode#182445. Thoughts?

@jerch
Copy link
Owner

jerch commented May 15, 2023

Yes moving it over as official addon would remove some of the typing quirks it currently faces. 👍

Regarding the vscode integration - maybe its a good idea to mention, that images are currently not yet part of the restored terminal content (would avoid getting issue reports regarding this).

@Tyriar
Copy link
Author

Tyriar commented May 15, 2023

@jerch yep, called that out in the setting and microsoft/vscode#182445. When I add does on the support I'll call it out there to reduce some reports until it works

@jerch
Copy link
Owner

jerch commented Jun 9, 2023

@Tyriar FYI - did a last addon release from this repo for xtermjs 5.2, as it was more convenient for me at the current stage. Will move things over to the main repo in the next weeks, so prolly with the next minor of xtermjs the addon can be packed from there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants