Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preorder and postorder functions #18

Open
jeromekelleher opened this issue Jul 6, 2022 · 3 comments
Open

Add preorder and postorder functions #18

jeromekelleher opened this issue Jul 6, 2022 · 3 comments

Comments

@jeromekelleher
Copy link
Owner

We can't rely on having the preorder and postorder methods from tskit anymore, so we'll need to have a way to compute them (returning arrays). Preorder is easily done with a stack. We can do postorder using recursion for now for simplicity.

We should also consider defining these as dataset variables, so we reuse them if we want to.

@benjeffery
Copy link
Collaborator

We should also consider defining these as dataset variables, so we reuse them if we want to.

Might be time to have a specification document somewhere for the dataset? Given this and the MCRA array?

@Billyzhang1229
Copy link
Contributor

We should also consider defining these as dataset variables, so we reuse them if we want to.

Might be time to have a specification document somewhere for the dataset? Given this and the MCRA array?

Yep, I think we should write down the variable definitions may be in a markdown file?

@jeromekelleher
Copy link
Owner Author

SGTM - we can formalise more later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants