Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assign id-tags to views (and other yet unidentifid items) #57

Open
lfertig opened this issue Nov 4, 2019 · 1 comment
Open

assign id-tags to views (and other yet unidentifid items) #57

lfertig opened this issue Nov 4, 2019 · 1 comment

Comments

@lfertig
Copy link
Collaborator

lfertig commented Nov 4, 2019

Describe the bug
views (and group collections) are currently not id-tagged, which causes unwanted behaviour when trying to fetch objects by uuid

To Reproduce
-see issue #55

Expected behavior
*all items that have an uuid in rhino should have one assigned in blender

Additional context
NamedViews are missing a variable that needs to be exposed in the bindings.

opennurbs_3dm_settings.h:

  ///////////////////////////////////////////////////////////////////////
  //
  // Named view information
  //
  // If this view was created from a named view, then m_named_view_id 
  // identifies the named view.
  //
  // The named views are ON_3dmView classes saved in ON_3dmSettings.m_named_views[].
  // A named view's id is the value returned by ON_3dmView.m_vp.ViewportId()
  // A named view's name is the value returned by ON_3dmView.m_name
  //
  // If this view is a named view, then m_named_view_id should be equal to
  // m_vp.m_viewport_id.
  //
  // If this view is not a named view and not created from a named view,
  // then m_named_view_id is equal to ON_nil_uuid.
  ON_UUID m_named_view_id;  
@lfertig
Copy link
Collaborator Author

lfertig commented Dec 14, 2019

I'm working on this right now. I had to add some lines to rhino3dm to expose the view_id. The thing is, only NamedViews have a guid, the standard views return zeroes (see screenshot). I'm wondering if this is going to cause us any hard time when filtering for objects? At least they're going to have the id tag set, so we wouldn't run into the error mentioned in #55 anymore..
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant