Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using 0.10.0-rc0X breaks policies #33

Open
AACO opened this issue May 12, 2021 · 2 comments
Open

Using 0.10.0-rc0X breaks policies #33

AACO opened this issue May 12, 2021 · 2 comments

Comments

@AACO
Copy link

AACO commented May 12, 2021

When upgrading from 0.9.1 to any 0.10.0 release candidate the policy blocks fail to be applied.
Config:

jgitver {
  policy {
    pattern = '(.*)'
    transformations = ['REMOVE_UNEXPECTED_CHARS', 'LOWERCASE_EN']
  }
}

Command: .\gradlew.bat clean version

0.9.1 output

> Task :version
Version: 1.0.1-1-featureruntimecerts

0.10.0-rc03 output

> Task :version
Version: 1.0.1-1-feature_runtime_certs

Gradle version:

------------------------------------------------------------
Gradle 6.3
------------------------------------------------------------

Build time:   2020-03-24 19:52:07 UTC
Revision:     bacd40b727b0130eeac8855ae3f9fd9a0b207c60

Kotlin:       1.3.70
Groovy:       2.5.10
Ant:          Apache Ant(TM) version 1.10.7 compiled on September 1 2019
JVM:          12 (Oracle Corporation 12+33)
OS:           Windows 10 10.0 amd64
@AACO
Copy link
Author

AACO commented May 12, 2021

After digging into it more, this looks like a strange issue with the plantir docker plugin trying to get the version before the jgitver plugin has loaded it's settings causing jgitver to be stuck with default settings. Seems like a catch 22 in terms of initialization between the plugins

@invpos
Copy link

invpos commented Aug 10, 2021

This is bothering me, too. I have an identical policy and the underscores are not being removed with 0.10.0-rc03. In my case, I have no incompatible plugins AFAIK. But underscores are not legal according to semver and npm takes this seriously:

# npm version 0.0.0-NOT_A_GIT_REPOSITORY
npm ERR! Invalid version: 0.0.0-NOT_A_GIT_REPOSITORY

Either the profile must be enforced for the 3 default qualified version numbers, or an option must be added to specify semver-compliant version numbers for these three. I am writing a separate issue stating this specific request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants