Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inaccurate "failed setup" initializing an account with no feeders #74

Open
jhansche opened this issue Nov 5, 2023 · 1 comment
Open
Assignees
Labels
bug Something isn't working

Comments

@jhansche
Copy link
Owner

jhansche commented Nov 5, 2023

If login succeeds, but there are no feeders on the account, HA reports "Failed setup, will retry". Logs show there were no failures, and login succeeded, but the feeders array is empty.

This should be an allowed scenario, especially since there are no errors logged for the "Failed setup" condition. There would just be no devices created.

This can be encountered by removing the last feeder from an account that had already been integrated successfully - as if an error is raised, the config flow would prevent adding the integration in the first place.

Once this is resolved, it should allow both scenarios: adding the integration using an account with no feeders associated, and also refreshing an already integrated account after removing the last feeder.

@jhansche jhansche self-assigned this Nov 5, 2023
@jhansche jhansche added the bug Something isn't working label Nov 5, 2023
@jhansche
Copy link
Owner Author

The fix should be to add the account as a "hub", and 0 or more feeders can be associated with that hub account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant