Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 8.5.0 with Spring Boot 3.3.0 #26247

Closed
mraible opened this issue May 23, 2024 · 18 comments
Closed

Release 8.5.0 with Spring Boot 3.3.0 #26247

mraible opened this issue May 23, 2024 · 18 comments
Labels
$$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ theme: java $500 https://www.jhipster.tech/bug-bounties/
Milestone

Comments

@mraible
Copy link
Contributor

mraible commented May 23, 2024

Overview of the feature request

Release 8.5.0 with Spring Boot 3.3.0, code quality fixes, and more type safety.

Motivation for or Use Case

It's good to keep up with Spring Boot releases. The upgrade to Angular 18 will have to wait for a minor release since related libraries haven't been updated yet.

Related issues or PR
@mraible
Copy link
Contributor Author

mraible commented May 23, 2024

@qmonmert @DanielFran @mshima @Tcharl Please let me know if there's anything you'd like to see fixed before this release.

@mraible mraible added $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ $500 https://www.jhipster.tech/bug-bounties/ theme: java labels May 23, 2024
@qmonmert
Copy link
Contributor

@mraible nothing for me

@mshima
Copy link
Member

mshima commented May 24, 2024

I have a few things before 8.5.0.

@Tcharl
Copy link
Contributor

Tcharl commented May 24, 2024

On my side I'm just improving the codebase right now, so long run and no end user impact (not even blueprint dev for now I think). So release can be done whenever you want.

@DanielFran
Copy link
Member

All good on my side, but maybe we should update the maven wrapper to version 3.3.2, this will fix some windows issues.
Confirmed it works now on bom project: jhipster/jhipster-bom#1581!

@mshima
Copy link
Member

mshima commented May 24, 2024

I agree, we had problems with v3.3.0 and v3.3.1.

@mshima
Copy link
Member

mshima commented May 24, 2024

On my side v8.5.0 can be released once #26261 is merged.

@mraible
Copy link
Contributor Author

mraible commented May 24, 2024

It's a long holiday weekend in the US so I probably won't do anything until Tuesday morning. I'll make sure and respond to the voting email on the developer mailing list and give timelines once I'm more certain.

@mshima
Copy link
Member

mshima commented May 28, 2024

Please wait for #26281.

@mshima
Copy link
Member

mshima commented May 28, 2024

Please wait for #26281.

Done

@mraible
Copy link
Contributor Author

mraible commented May 29, 2024

Should we wait until the next version of Spring Cloud is released? It's scheduled for tomorrow. https://github.com/spring-cloud/spring-cloud-release/milestones

@mshima
Copy link
Member

mshima commented May 29, 2024

Should we wait until the next version of Spring Cloud is released? It's scheduled for tomorrow. https://github.com/spring-cloud/spring-cloud-release/milestones

Looks ok to me.

@mraible
Copy link
Contributor Author

mraible commented May 29, 2024

Look OK to release or to wait for the next version of Spring Cloud? I asked because I saw this issue: spring-cloud/spring-cloud-release#287.

@mshima
Copy link
Member

mshima commented May 29, 2024

Look OK to release or to wait for the next version of Spring Cloud? I asked because I saw this issue: spring-cloud/spring-cloud-release#287.

😄 your call.
I am ok to wait a couple more days for next spring-cloud.
Spring Boot v3.3.1 is scheduled for June 20, next generator-jhipster should be after it.

@mraible
Copy link
Contributor Author

mraible commented May 29, 2024

OK, I'll wait until Spring Cloud 2023.0.2 is released and upgraded in JHipster.

@mraible
Copy link
Contributor Author

mraible commented May 30, 2024

The Spring Cloud 2023.0.2 upgrade is at jhipster/jhipster-bom#1591.

@mraible mraible closed this as completed May 31, 2024
@mraible mraible added this to the 8.5.0 milestone May 31, 2024
@mraible
Copy link
Contributor Author

mraible commented Jun 5, 2024

@DanielFran
Copy link
Member

@mraible approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
$$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ theme: java $500 https://www.jhipster.tech/bug-bounties/
Projects
None yet
Development

No branches or pull requests

5 participants