-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
links to new tab #227
Comments
Sounds like a great idea. I’ll take a look into it. |
This doesn't work in Leanpub so that's what's kind of holding me up for implementing this currently. |
Now that Leanpub is using our iframes, we can do |
This issue is now obsolete with the iframe thing. |
I wonder if we want reference links to also go to a new tab? So not citation... but references. But yeah, this is already so much better! :) |
Yes ideally we want all links to go to a new window. So I'll reopen this issue. |
Is this still an issue that I should assign myself? |
I think it is worth at least checking how references and citations are navigated :) |
Testing some references in the AI course bookdowns, they don't open in a new tab. I know adding the attribute |
Echoing @kweav : The references in the AI for Decision Makers don't open in a new tab. I'll look into this right now. |
Potentially useful code I found on the Internet: https://yihui.org/en/2018/09/target-blank/#open-external-links-in-new-tabs-automatically |
@kweav I'll take this issue and will work on a fix in this new branch I created from this issue: |
Is your feature request related to a problem? Please describe.
It would be nice if when users clicked on a reference it took them to a new tab so that they don't lose their place in the chapter.
Describe the solution you'd like
Users could click on a reference and a new tab would open. Then they could return to reading the course
Describe alternatives you've considered
perhaps we can modify leanbuild to add target="_blank" and rel="noreferrer noopener"
Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered: