Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving Password Encryption with AES-256 and PBKDF2 algos! #122

Closed
Ishratnoori opened this issue Oct 20, 2024 · 10 comments
Closed

Improving Password Encryption with AES-256 and PBKDF2 algos! #122

Ishratnoori opened this issue Oct 20, 2024 · 10 comments
Assignees
Labels
enhancement New feature or request gssoc-ext GSSoC'24 Extended hacktoberfest-accepted hacktoberfest 2024 level2 gssoc: level 2

Comments

@Ishratnoori
Copy link

Hello Maintainers,

I’d like to help with the passOP project by "Enhancing the password encryption" by upgrading to a more secure method.
This feature will improve the security of the password manager system.

Could you please assign this issue to me?
I’m looking forward to contributing!

Best regards,
Ishrat :)
(Please assign me under gssoc-ext and hacktoberfest;))

@jinx-vi-0
Copy link
Owner

@jindalpriyanshu101 can you please look into this .

@jindalpriyanshu101
Copy link
Contributor

hi @Ishratnoori, we would love to know how you're going to enhance the current encryption. please explain your approach

@jindalpriyanshu101 jindalpriyanshu101 added question Further information is requested gssoc-ext GSSoC'24 Extended hacktoberfest-accepted hacktoberfest 2024 labels Oct 25, 2024
@Ishratnoori
Copy link
Author

Ishratnoori commented Oct 26, 2024

Hi @jindalpriyanshu101! As I'm focusing on cybersecurity, I'm planning to enhance encryption by using a combination of AES-256 and PBKDF2. This is my basic idea:

  1. AES-256 Encryption : encrypts passwords with strong 256-bit key to keep data safe
  2. PBKDF2 Key Derivation: I’ll use pbkdf2 to create the encryption key, and applying multiple rounds of hashing. this makes it harder for attackers to crack

Together, AES-256 nd PBKDF2 make the encryption tougher to break, also increases security. let me know if u'd like to add anything!!

@jindalpriyanshu101
Copy link
Contributor

Sounds good, start working on it @Ishratnoori

@jindalpriyanshu101 jindalpriyanshu101 added enhancement New feature or request level2 gssoc: level 2 and removed question Further information is requested labels Oct 27, 2024
@Ishratnoori
Copy link
Author

Ishratnoori commented Oct 28, 2024

Hi @jindalpriyanshu101,

I’ve implemented the password encryption enhancements using AES-256 and PBKDF2.
The changes are ready for review.
Please check them out and merge if everything looks good. Lemme know if you have any suggestions or see any areas for further improvement!

Thanks a ton!

@jindalpriyanshu101
Copy link
Contributor

Hey @Ishratnoori is there any update on this issue?

@Ishratnoori
Copy link
Author

Hi @jindalpriyanshu101 and @jinx-vi-0,

I have successfully pushed the full AES-256 and PBKDF2 encryption enhancements in the new-feature-branch. You can find the changes in the pull request I created.

Thank you for your guidance throughout this process!

@jindalpriyanshu101
Copy link
Contributor

Hi @Ishratnoori, i'm expecting you to raise your changes before 6pm today. And in-case you're unable to resolve those merge conflicts, contact me through discord so that actual changes can be pushed and merged.

@Ishratnoori
Copy link
Author

Uploading image.png…
This is the output

@jinx-vi-0
Copy link
Owner

times up.

@jinx-vi-0 jinx-vi-0 closed this as not planned Won't fix, can't repro, duplicate, stale Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gssoc-ext GSSoC'24 Extended hacktoberfest-accepted hacktoberfest 2024 level2 gssoc: level 2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants