Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get tests running again #674

Open
jkomoros opened this issue Nov 13, 2023 · 1 comment
Open

Get tests running again #674

jkomoros opened this issue Nov 13, 2023 · 1 comment

Comments

@jkomoros
Copy link
Owner

It's been awhile and they've started failing for small reasons.

Mac Pro doesn't even have java installed!
jkomoros added a commit that referenced this issue Nov 13, 2023
@jkomoros
Use named imports, since some of the node tests don't like not having…
7c090f4 
… it.

Part of #674.
@jkomoros
Copy link
Owner Author

#674 broke a couple of the tests that rely on constants that no longer exist.

Ideally we'd move to typescript for the tests.

Broken currently:

test:references, test:fingerprint, test:url

jkomoros added a commit that referenced this issue Nov 14, 2023
@jkomoros
Make the convenience methods for types use zod.parse
1ce3536 
So if they're used from a non-typescript context (like tests) they'll fail immediately.

Part of #674. Part of #673.
jkomoros added a commit that referenced this issue Nov 14, 2023
@jkomoros
Make cardType be a convenience warpper for types.
ee1b975 
Useful for #673. Part of #674.
jkomoros added a commit that referenced this issue Nov 14, 2023
@jkomoros
Use cardType getter in references test, making it pass again.
2410ad7 
Part of #673. Part of #674.
jkomoros added a commit that referenced this issue Nov 14, 2023
@jkomoros
Use cardType and referenceType to get test:fingerprint working again.
c2d3d3e 
Part of #674. Part of #673.
jkomoros added a commit that referenced this issue Nov 14, 2023
@jkomoros
Fix a bunch of auto-fixable lint problems.
29bb8a2 
Part of #674.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jkomoros