Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove accidental block layout within tag-list #678

Open
3 tasks
jkomoros opened this issue Nov 23, 2023 · 0 comments
Open
3 tasks

Remove accidental block layout within tag-list #678

jkomoros opened this issue Nov 23, 2023 · 0 comments
Labels
cleanup No change in user behavior, just code cleanup and refactoring

Comments

@jkomoros
Copy link
Owner

jkomoros commented Nov 23, 2023 •
edited
Loading

<tag-list> has had an accidental div block layout element inside of it for a long time, which makes it impossible to use tag-list in an inline context.

This feels like the wrong default, but a lot of existing use of tag-list accidentally relies on this old behavior.

Noted while working on #670.

  • Add a .block, and use in all legacy cases
  • Remove tag-list.block behavior in all cases
  • Remove the block property and classes
@jkomoros jkomoros added the cleanup No change in user behavior, just code cleanup and refactoring label Nov 23, 2023
jkomoros added a commit that referenced this issue Nov 23, 2023
@jkomoros
Add a tag-list.inline
89a837e 
The behavior has been a block accidentally, and changing the behavior would break a lot of layouts. I
considered adding a .block and using it for all legacy uses, but I think that the current behavior is
better in a number of cases.

Part of #678. Part of #670.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup No change in user behavior, just code cleanup and refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jkomoros