Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using signInWithRedirect #693

Open
jkomoros opened this issue Apr 20, 2024 · 1 comment
Open

Stop using signInWithRedirect #693

jkomoros opened this issue Apr 20, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@jkomoros
Copy link
Owner

Starting June 18 2024 it will stop working apparently

https://firebase.google.com/docs/auth/web/redirect-best-practices
jkomoros added a commit that referenced this issue Apr 20, 2024
@jkomoros
Switch to signInWithPopup.
c967070 
This is a bit of an annoying UI but is better than doing the more confusing options to keep signInWithRedirect.

Part of #693.
@jkomoros
Copy link
Owner Author

c967070 may have broken sign in. There's an error like credential-already-in-use or something like that.

@jkomoros jkomoros added the bug Something isn't working label Jun 22, 2024
jkomoros added a commit that referenced this issue Jun 23, 2024
@jkomoros
Fix it so logging in on a fresh profile works again.
f499142 
Part of #693.

This was likely broken in c967070, since I was hooking getRedirectResult incorrectly. Claude suggested the new contents of signIn().
jkomoros added a commit that referenced this issue Jun 27, 2024
@jkomoros
Attempt to fix a login bug with merging accounts.
3057c9c 
Before this, if you logged in to a previously existing account, the confirmation prompt would be auto-closed by Chrome because the popup was still showing, and print: `A window.confirm() dialog generated by this page was suppressed because this page is not the active tab of the front window. Please make sure your dialogs are triggered by user interactions to avoid this situation. https://www.chromestatus.com/feature/5140698722467840`

Because it would be auto-canceled, the sign in would be stopped according to our code.

This change attempts to change timing so the popup is closed when that happens. Not sure if it works.

Part of #693.
jkomoros added a commit that referenced this issue Jun 29, 2024
@jkomoros
Add a short timeout during account merging for the popup to close.
617eca3 
... At least, hopefully.

Part of #693.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jkomoros