Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minors 10.1 > 10.2 #27

Closed
poohui opened this issue Feb 14, 2014 · 1 comment
Closed

minors 10.1 > 10.2 #27

poohui opened this issue Feb 14, 2014 · 1 comment
Assignees
Labels

Comments

@poohui
Copy link

poohui commented Feb 14, 2014

some glyphs in minors have values in wrong order
10.1 shows +142 and 10.2 shows +129


--- tswcalc/src/javascript/data/tswcalc-data-glyphs.js  2014-02-14 12:53:41.180994184 +0200
+++ tswcalc-data-glyphs.js  2014-02-14 12:51:30.244990023 +0200
@@ -83 +83 @@
-                                4: 142
+                                4: 129
@@ -123 +123 @@
-                                4: 129
+                                4: 142
@@ -327 +327 @@
-                                4: 142
+                                4: 129
@@ -367 +367 @@
-                                4: 129
+                                4: 142
@@ -1059 +1059 @@
-                                4: 142
+                                4: 129
@@ -1099 +1099 @@
-                                4: 129
+                                4: 142
@@ -1303 +1303 @@
-                                4: 142
+                                4: 129
@@ -1343 +1343 @@
-                                4: 129
+                                4: 142
@@ -2203 +2203 @@
-};
\ No newline at end of file
+};
@joakibj
Copy link
Owner

joakibj commented Feb 14, 2014

You are right, I'll make a new release and deploy for this. Looks like affects hit-rating, penetration-rating, defense-rating and block-rating glyphs.

Thanks. I guess the reason why this went undetected for so long, is that most don't calculate glyphs based on 10.1 or 10.2

@joakibj joakibj added the bug label Feb 14, 2014
@joakibj joakibj self-assigned this Feb 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants