Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combat Power Update #36

Merged
merged 3 commits into from
Oct 12, 2015
Merged

Combat Power Update #36

merged 3 commits into from
Oct 12, 2015

Conversation

Xeio
Copy link
Contributor

@Xeio Xeio commented Oct 8, 2015

This change should resolve #35 for AR values above 5200.

@joakibj
Copy link
Owner

joakibj commented Oct 9, 2015

Could you fix the formatting please?

if(true) {
  return something;
} else {
  return somethingElse;
}

Also, add a test to summary.js if you could :)

Afterwards, I'll merge this in after the release with BB rebalancing. This is then gonna get released and deployed after it hits Live.

@Xeio
Copy link
Contributor Author

Xeio commented Oct 12, 2015

Done, though I contend it was fully ok for my C# style guidelines to leak into javascript land. :P

joakibj pushed a commit that referenced this pull request Oct 12, 2015
Merge pull request #36 from Xeio/issue12
0a3fbc6 
Combat Power Update
@joakibj joakibj merged commit 0a3fbc6 into joakibj:develop Oct 12, 2015
@joakibj
Copy link
Owner

joakibj commented Oct 12, 2015

Awesome, nice! Can't have too many tests ;)

This goes live when the patch goes live.

@joakibj joakibj added this to the 1.6.2 milestone Oct 21, 2015
@joakibj joakibj self-assigned this Oct 21, 2015
@Xeio Xeio deleted the issue12 branch October 29, 2015 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@joakibj joakibj

Labels
refactor
Projects
None yet
Milestone
1.6.2
Development

Successfully merging this pull request may close these issues.

Combat Power Calculation Update
2 participants
@Xeio @joakibj