Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 13 (Shambala) Signet Support #47

Closed
Xeio opened this issue Jan 29, 2016 · 3 comments
Closed

Issue 13 (Shambala) Signet Support #47

Xeio opened this issue Jan 29, 2016 · 3 comments
Labels

Comments

@Xeio
Copy link
Contributor

Xeio commented Jan 29, 2016

Opening issue to track this until someone has time to add them to the data files.

Spreadsheet from @Inkraja: https://docs.google.com/spreadsheets/d/11AOygXcnzmZHr9bdLmntGEUgCZWA9t5EdKGZYzYuNns/edit?usp=sharing

We may want to verify these are still accurate as of Live yesterday too.

@joakibj
Copy link
Owner

joakibj commented Feb 4, 2016

Yeah looks like this is all about punching data to: https://github.com/joakibj/tswcalc/blob/develop/src/javascript/data/tswcalc-data-signets.js . Only issue is icons, which imo should just show a decent placeholder.

@Inkraja
Copy link
Contributor

Inkraja commented Mar 16, 2016

check this out: Inkraja@9e29492

there are 3 /!!/ there are open question because the heal is based on the heal raiting, but i didnt know the formular for it. And one is for the Coup de Grâce Signet....

@Xeio
Copy link
Contributor Author

Xeio commented Mar 16, 2016

I'll just note though we talked about it in TS:

  • Coup de Grâce name is fine
  • Don't use signet IDs 80-93
  • Move the signets to the exsiting 'major', 'minor', ect lists
  • Possibly use something like "shambala: true" rather than "requires: 'issue-14'", requires is coded to be used for the Venice vendor items specifically, so probably best to avoid that code running for these

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants