Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future non-custom item support (NM Raid drops) #48

Closed
Xeio opened this issue Jan 29, 2016 · 3 comments
Closed

Future non-custom item support (NM Raid drops) #48

Xeio opened this issue Jan 29, 2016 · 3 comments
Labels

Comments

@Xeio
Copy link
Contributor

Xeio commented Jan 29, 2016

Opening an issue to track this and separate discussion from glyphs in #44.

I'd like to throw a mockup or two together for this at some point, since I'd rather move away from checkboxes for non-custom items.

I don't think any non-custom items were confirmed in the first NM NY kill, so this is still relatively low priority. If we get custom 10.6 glyphs working, then the MF:B dungeon drops probably aren't strictly necessary to implement (though I suppose they wouldn't be terrible to have).

@joakibj
Copy link
Owner

joakibj commented Jan 29, 2016

Agree that the checkboxes are not viable. Please check out #49 as well

@Xeio
Copy link
Contributor Author

Xeio commented Feb 18, 2016

Sort of playing with a prototype for this functionality. Any thoughts? Not doing any sort of huge rewrite re-style at the moment. Just moving to be a bit more scalable as a select box.

Only moved the Head/Woodcutters talismans to the new format at the moment to play around with.

Can view it here: http://tswcalc.azurewebsites.net/

Still buggy, layout issues, some boxes don't disable on import of custom items (though import does work). I think I may have also broken literally every unit test but I can worry about that later as I'd rather not do all the work and then we decide this isn't a good way to do it. :P

@joakibj
Copy link
Owner

joakibj commented Feb 19, 2016

Looks good. Could maybe rename the Role term to Item or something. Then change "DPS" to "Custom DPS" or something like that. Definitely more scalable when it comes to more raid drops etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants