Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can standalone use outputs of ui-only build? #8

Open
theborakompanioni opened this issue Feb 8, 2022 · 0 comments
Open

Can standalone use outputs of ui-only build? #8

theborakompanioni opened this issue Feb 8, 2022 · 0 comments

Comments

@theborakompanioni
Copy link
Collaborator

theborakompanioni commented Feb 8, 2022 •
edited
Loading

Currently both, standaloneand ui-only will build the ui from scratch, meaning downloading node_modules and invoking npm run build. Can the standalone build reuse the outputs of ui-only easily? Is that compatible with the GitHub workflow approach?

It'd be cool to just define something like this in the Dockerfile for standalone:

FROM ghcr.io/joinmarket-webui/joinmarket-webui-dev-ui-only:vX.X.X AS ui-only
COPY --from=ui-only /app /app
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@theborakompanioni