-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CoffeeScript dependency #37
Comments
Unfortunately that won't fix it, code changes need to be made to the coffee-react-transform parser based on the upstream changes in the coffeescript lexer to support this new syntax. |
What do you think needs to be done to the parser to add support? I guess I just can't find anywhere in the parser that would need to transform object keys. I might try and get my hands dirty if it's not too involved. |
Actually it looks like you are right, the coffee-react-transform process should pass this syntax through untouched. In fact, the coffee-react npm package specifies a dependency on coffeescript with a loose dependency constraint of |
Could you publish the new version of grunt-coffee-react? Current version depends on on coffee-react |
Same boat here, trying to build a project with Love all the work you've done so far, @jsdf, thanks for everything! |
Published coffee-react v5.0.0 and grunt-coffee-react v5.0.0 which update the coffeescript dep to |
You live up to your name, truly a friend. |
In order to fix jsdf/coffee-react-transform#66, we should be able to just update the
coffee-script
dependency. The feature to allow interpolations in object keys was added in this commit: jashkenas/coffeescript@76c076d. If I created a PR, how soon could you merge it in and cut a new release? Are there other blockers to updating CS that I'm overlooking?The text was updated successfully, but these errors were encountered: