Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CoffeeScript dependency #37

Closed
ezekg opened this issue Apr 14, 2016 · 7 comments
Closed

Update CoffeeScript dependency #37

ezekg opened this issue Apr 14, 2016 · 7 comments

Comments

@ezekg
Copy link

ezekg commented Apr 14, 2016

In order to fix jsdf/coffee-react-transform#66, we should be able to just update the coffee-script dependency. The feature to allow interpolations in object keys was added in this commit: jashkenas/coffeescript@76c076d. If I created a PR, how soon could you merge it in and cut a new release? Are there other blockers to updating CS that I'm overlooking?

@jsdf
Copy link
Owner

jsdf commented Apr 14, 2016

Unfortunately that won't fix it, code changes need to be made to the coffee-react-transform parser based on the upstream changes in the coffeescript lexer to support this new syntax.

@ezekg
Copy link
Author

ezekg commented Apr 15, 2016

What do you think needs to be done to the parser to add support? I guess I just can't find anywhere in the parser that would need to transform object keys. I might try and get my hands dirty if it's not too involved.

@jsdf
Copy link
Owner

jsdf commented Apr 16, 2016

Actually it looks like you are right, the coffee-react-transform process should pass this syntax through untouched. In fact, the coffee-react npm package specifies a dependency on coffeescript with a loose dependency constraint of ^1.9.1 which means that all you have to do is rm -rf coffee-react and reinstall it, and it should install the latest version of coffeescript (assuming that coffeescript is currently being installed as a dependency of coffee-react and not directly in your project's node-modules directory beside coffee-react).

@ezekg
Copy link
Author

ezekg commented Apr 18, 2016

Could you publish the new version of grunt-coffee-react? Current version depends on on coffee-react 2.4.1, which has a hard dependency on CoffeeScript 1.8.0. Thanks!

image

@jeffmicklos
Copy link

Same boat here, trying to build a project with grunt-coffee-react that has interpolated object keys!

Love all the work you've done so far, @jsdf, thanks for everything!

@jsdf
Copy link
Owner

jsdf commented Apr 22, 2016

Published coffee-react v5.0.0 and grunt-coffee-react v5.0.0 which update the coffeescript dep to ^1.10.0

@jsdf jsdf closed this as completed Apr 22, 2016
@jeffmicklos
Copy link

You live up to your name, truly a friend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants