Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Handle 304 caching for checkReleases #47

Closed
guybedford opened this issue May 4, 2015 · 2 comments
Closed

Handle 304 caching for checkReleases #47

guybedford opened this issue May 4, 2015 · 2 comments

Comments

@guybedford
Copy link
Member

Because caching.

@crisptrutski
Copy link
Contributor

Implementing the obvious ETag based caches for getPackageConfig and checkReleases. locate is trickier - the current implementation uses the website, which does not seem so support If-Modified-Since or If-None-Match.

Will try out a solution where /users/<owner>/repos/ is cached and used for these lookups. Since this will leave us blind to repo renames, we'll still fail over to the website call (which is still indeterminate - and may fall through to lookup to reject).

Cannot see any way to cache lookup - ls-remote doesn't seem to provide any quick check for changes. That's OK because probably most time is spent in negotiation and calculating and sending the heads is probably negligible.

No cache required for downloads - lean on JSPM cache there

@guybedford
Copy link
Member Author

There are three large requests here: checkReleases, locate and ls-remote for lookup. As @crisptrutski notes, we can't cache ls-remote unless we internally implement the git request, so that's blocked on #25. lookup can actually now be handled via #54, so that just leaves checkReleases as the main thing to cache here.

Renaming title to match.

@guybedford guybedford changed the title Handle 304s for API requests Handle 304 caching for checkReleases Aug 3, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants