Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incoperate statix? #124

Open
Mic92 opened this issue Oct 29, 2021 · 5 comments
Open

Incoperate statix? #124

Mic92 opened this issue Oct 29, 2021 · 5 comments

Comments

@Mic92
Copy link

Mic92 commented Oct 29, 2021

@NerdyPepper build this handy tool.
I looks like nice extension to the already existing checks in nixpkgs-hammering.
Thoughts?

@jtojnar
Copy link
Owner

jtojnar commented Oct 29, 2021 via email

@oppiliappan
Copy link

On the other hand, n-h seems to have more detailed error descriptions.

Yeah, statix currently does not describe/explain issues at all. I do have "offline explanation" on the roadmap though. I see n-h also has a bunch of tests, statix does not have any tests at the moment.

so that we do not need both Rust and Python in the closure

I am not too familiar with nixpkgs-hammering's codebase, how many checks depend on python? Are they trivial enough to translate to Rust?

I'd definitely like to see unison in developer tools around Nix, my end goal is to have all of this reside in rnix-lsp, or atleast integrate with it.

@jtojnar
Copy link
Owner

jtojnar commented Oct 30, 2021

The most of the checks are written in Nix so the Python basically just constructs Nix code, runs nix-instantiate and the compiled rust binaries, and then joins the result JSONs and formats them.

Should be pretty easy to port to rust https://github.com/jtojnar/nixpkgs-hammering/blob/a24b5537fab53dec6dc638576bff19606ad4a33b/tools/nixpkgs-hammer

@Mic92
Copy link
Author

Mic92 commented Oct 30, 2021

@jtojnar
Copy link
Owner

jtojnar commented Oct 30, 2021

Yeah, currently the checks are compiled into programs which output JSON results when run and are executed by the Python program. I want to have Rust do everything so it is easier to package in Nixpkgs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants