New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposed hammer: Prefer `''${ENV_VAR}` over `${ENV_VAR}` #142

Open

pbsds opened this issue Oct 1, 2023 · 0 comments

Labels

pbsds commented Oct 1, 2023

This is for the sake of overrideability

Such a lint/hammer would catch this test case, which is broken:

(mkDerivation rec {
  ...
  BUILD_COMMAND = "production";
  buildPhase = ''
    npm run "${BUILD_COMMAND}"
  '';
}).overrideAttrs (_: {
  BUILD_COMMAND="development";
})

jtojnar added the checks/syntax label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment