Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

child mount process should not exit when we kill the parent process. #5448

Open
zhoucheng361 opened this issue Dec 26, 2024 · 2 comments
Open

Comments

@zhoucheng361
Copy link
Contributor

What happened:
https://github.com/juicedata/juicefs/actions/runs/12496360301/job/34868010820

root@bench-01:~/juicefs# ps -ef | grep mount
tidb      375693       1  0 Dec18 ?        00:00:00 bin/node_exporter/node_exporter --web.listen-address=:9100 --collector.tcpstat --collector.mountstats --collector.meminfo_numa --collector.buddyinfo --collector.vmstat.fields=^.* --log.level=info
root     1130951       1  0 17:37 ?        00:00:00 ./juicefs mount sqlite3:///root/juicefs/test.db /tmp/jfs -d
root     1131018 1130951  1 17:37 ?        00:00:00 /root/juicefs/juicefs mount sqlite3:///root/juicefs/test.db /tmp/jfs -d
root     1131100 1130795  0 17:37 pts/4    00:00:00 grep --color=auto mount
root@bench-01:~/juicefs# kill 1130951
root@bench-01:~/juicefs# ps -ef | grep mount
tidb      375693       1  0 Dec18 ?        00:00:00 bin/node_exporter/node_exporter --web.listen-address=:9100 --collector.tcpstat --collector.mountstats --collector.meminfo_numa --collector.buddyinfo --collector.vmstat.fields=^.* --log.level=info
root     1131114 1130795  0 17:37 pts/4    00:00:00 grep --color=auto mount

What you expected to happen:
child process should not exit when we kill the parent process.

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?

Environment:

  • JuiceFS version (use juicefs --version) or Hadoop Java SDK version:
  • Cloud provider or hardware configuration running JuiceFS:
  • OS (e.g cat /etc/os-release):
  • Kernel (e.g. uname -a):
  • Object storage (cloud provider and region, or self maintained):
  • Metadata engine info (version, cloud provider managed or self maintained):
  • Network connectivity (JuiceFS to metadata engine, JuiceFS to object storage):
  • Others:
@zhoucheng361 zhoucheng361 added the kind/bug Something isn't working label Dec 26, 2024
@zhoucheng361
Copy link
Contributor Author

@zhijian-pro zhijian-pro self-assigned this Dec 27, 2024
@zhijian-pro zhijian-pro removed the kind/bug Something isn't working label Dec 27, 2024
@zhijian-pro
Copy link
Contributor

In version 1.2, when the parent process receives a term signal, it will not pass it on to the child process, and the child process will become orphaned. After this PR, the parent process will pass the term signal to the child process, and the child process will exit proactively.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants