Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using percentage instead of fixed numbers in touch locations #3

Open
hijazi opened this issue Dec 18, 2017 · 5 comments
Open

Using percentage instead of fixed numbers in touch locations #3

hijazi opened this issue Dec 18, 2017 · 5 comments

Comments

@hijazi
Copy link

hijazi commented Dec 18, 2017

When running the code you give a warning height of window must be 1080 and width of window must be 1920 and all touches and screen captures depend on these dimensions, however they are very difficult to get on laptop screens (I can see you have a very big screen).
So getting the dimensions of the emulator when first run and using percentages would be much better!

@hijazi hijazi closed this as completed Dec 18, 2017
@hijazi
Copy link
Author

hijazi commented Dec 18, 2017

very sorry closed by mistake!

@hijazi hijazi reopened this Dec 18, 2017
@hijazi
Copy link
Author

hijazi commented Dec 18, 2017

I've just understood why CentreMap is (960, 500), which is the end of the emulator on my screen! my emulator dimensions are about (1024 x 575)!

@hijazi
Copy link
Author

hijazi commented Dec 18, 2017

I'll work on turning the numbers into percentages.

@julianperrott
Copy link
Owner

This was a simply a proof of concept, and short cuts were taken, so many improvements in the code are required. I have no intention of taking it any further as I achieved what I set out to, and quickly reached a position in the game where it was no longer fun.

@hijazi
Copy link
Author

hijazi commented Dec 18, 2017

I really appreciate that you shared your code. I'm enjoying working on the code more than playing the game, so I'll see where this leads.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants