-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use new markdown-it plugins #8
Comments
Thanks for opening your first issue here! Engagement like this is essential for open source projects! 🤗 |
and yeh, as I've just mention on a jupyter thread, you can check out some of the plugin rendering at: |
Also to note, there is still activity going on around these plugins: executablebooks/meta#449 |
Once some more of those are merged in we can merge jupyter-book/mystmd#33 and then this package can consume the updates with a version bump. I think it is worth combining and having a myst-specific export (which this package is meant for). I am planning on getting back to the PRs that you reviewed last week today or tomorrow. |
Yep indeed 👍 just wanted to make @agoose77 of the changes, and start thinking about the config/css points |
Appreciate it all, I'm following this remotely! |
So, it seems to me that we have the following top-level plugins that we need to expose/require as jupyterlab-markup plugins:
* already provided by |
Yep, plus there are some "small" plugins currently directly implemented in https://github.com/executablebooks/myst-vs-code/blob/master/src/mdPlugins.ts |
Could we move that inline plugin into a new / existing package(s)? |
most certainly, this is where I was thinking markdown-it-myst might come in useful |
Ah OK. I'm not 100% confident with the entire MyST landscape yet, so I'm not clear on where everything goes. In my head, I envisage |
Ask and you shall receive 😉 |
Uses the `--jp-content-link-color` with a fallback. See #8
Essentially, this plugin should eventually mirror: https://github.com/executablebooks/myst-vs-code/blob/master/src/extension.ts
A few things to consider here:
cc @agoose77
The text was updated successfully, but these errors were encountered: