Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default hashtable size of 3097 #39

Open
cgzones opened this issue Jan 22, 2025 · 1 comment
Open

Default hashtable size of 3097 #39

cgzones opened this issue Jan 22, 2025 · 1 comment

Comments

@cgzones
Copy link

cgzones commented Jan 22, 2025

Since the addition of the apache 2.4 module in 7bf8c3c the default hashtable size is 3097:

#define DEFAULT_HASH_TBL_SIZE 3097UL // Default hash table size

3097 however is not a prime, and not in the ntt_prime_list array, so it actually means a default size of 6151.
Was that a typo and the value should be 3079, or should the value for clarity be set to 6151?
See also https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=833448

@jvdmr
Copy link
Owner

jvdmr commented Jan 23, 2025

Copy/pasted from the original code in https://github.com/jvdmr/mod_evasive/blame/7bf8c3c68b855be6508485b467ab4ae2db8bc645/mod_evasive14.c#L50, which I took over as-is from the original maintainer, so I'm guessing it was indeed a typo that has just been overlooked.

I didn't know about the bug report, thanks for mentioning it! I also didn't know the Debian package no longer had a maintainer. , so I figure I'll add myself there as the maintainer to hopefully provide better support there too. that seems to be a lot more involved than I am prepared for... Anyway I at least subscribed to the package's bugs page, hopefully I can make a difference that way 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants