From 5a5dbe07b5d6a4570551368b783e29680b59c73d Mon Sep 17 00:00:00 2001 From: Yuki Tsujii Date: Fri, 28 Oct 2022 03:55:24 +0900 Subject: [PATCH] =?UTF-8?q?localStrage=E3=82=92=E8=AA=AD=E3=81=BF=E8=BE=BC?= =?UTF-8?q?=E3=82=80=E3=81=8B=E3=81=A9=E3=81=86=E3=81=8B=E3=81=AFdefault:?= =?UTF-8?q?=20false=E3=81=A8=E3=81=AA=E3=82=8B=E3=82=88=E3=81=86=E3=81=AB?= =?UTF-8?q?=E5=A4=89=E6=9B=B4=20(#9146)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: mediaconsortium-develop --- modules/dgkeywordRtdProvider.js | 6 +++--- test/spec/modules/dgkeywordRtdProvider_spec.js | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/modules/dgkeywordRtdProvider.js b/modules/dgkeywordRtdProvider.js index 032cb4a780a..99df3b18a39 100644 --- a/modules/dgkeywordRtdProvider.js +++ b/modules/dgkeywordRtdProvider.js @@ -41,7 +41,7 @@ export function getDgKeywordsAndSet(reqBidsConfigObj, callback, moduleConfig, us } else { logMessage('[dgkeyword sub module] dgkeyword targets:', setKeywordTargetBidders); logMessage('[dgkeyword sub module] get targets from profile api start.'); - ajax(getProfileApiUrl(moduleConfig?.params?.url, moduleConfig?.params?.disableReadFpid), { + ajax(getProfileApiUrl(moduleConfig?.params?.url, moduleConfig?.params?.enableReadFpid), { success: function(response) { const res = JSON.parse(response); if (!isFinish) { @@ -96,9 +96,9 @@ export function getDgKeywordsAndSet(reqBidsConfigObj, callback, moduleConfig, us } } -export function getProfileApiUrl(customeUrl, disableReadFpid) { +export function getProfileApiUrl(customeUrl, enableReadFpid) { const URL = 'https://mediaconsortium.profiles.tagger.opecloud.com/api/v1'; - const fpid = (disableReadFpid) ? '' : readFpidFromLocalStrage(); + const fpid = (enableReadFpid) ? readFpidFromLocalStrage() : ''; let url = customeUrl || URL; url = url + '?url=' + encodeURIComponent(window.location.href) + ((fpid) ? `&fpid=${fpid}` : ''); return url; diff --git a/test/spec/modules/dgkeywordRtdProvider_spec.js b/test/spec/modules/dgkeywordRtdProvider_spec.js index 16f2906b681..754740b7a64 100644 --- a/test/spec/modules/dgkeywordRtdProvider_spec.js +++ b/test/spec/modules/dgkeywordRtdProvider_spec.js @@ -383,10 +383,11 @@ describe('Digital Garage Keyword Module', function () { } let moduleConfig = cloneDeep(DEF_CONFIG); window.localStorage.setItem('ope_fpid', uuid); + moduleConfig.params.enableReadFpid = true; dgRtd.getDgKeywordsAndSet( pbjs, () => { - const url = dgRtd.getProfileApiUrl(null); + const url = dgRtd.getProfileApiUrl(null, moduleConfig.params.enableReadFpid); expect(url.indexOf(uuid) > 0).to.equal(true); expect(url).to.equal(server.requests[0].url); done(); @@ -410,11 +411,10 @@ describe('Digital Garage Keyword Module', function () { } let moduleConfig = cloneDeep(DEF_CONFIG); window.localStorage.setItem('ope_fpid', uuid); - moduleConfig.params.disableReadFpid = true; dgRtd.getDgKeywordsAndSet( pbjs, () => { - const url = dgRtd.getProfileApiUrl(null, moduleConfig.params.disableReadFpid); + const url = dgRtd.getProfileApiUrl(null); expect(url.indexOf(uuid) > 0).to.equal(false); expect(url).to.equal(server.requests[0].url); done();