Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): add pyth to kaia docs #143

Merged
merged 3 commits into from
Oct 31, 2024

Conversation

mariobern
Copy link
Contributor

Proposed changes

Hi all,

We'd like to get featured in Kaia documentation as one of the leading oracles supporting the ecosystem.

Types of changes

Please put an x in the boxes related to your change.

  • Minor Issues and Typos
  • Major Content Contribution
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to reach out. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES
  • I have read the CLA and signed by comment I have read the CLA Document and I hereby sign the CLA in first time contribute
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

NA

Further comments

NA

Copy link

github-actions bot commented Oct 24, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@mariobern mariobern changed the title add pyth to kaia docs feat(docs): add pyth to kaia docs Oct 24, 2024
@ayo-klaytn
Copy link
Collaborator

ayo-klaytn commented Oct 24, 2024

Hi @mariobern Thanks for your contribution.

In the meantime, i'll like you to sign the CLA as suggested by the bot.

If you have done that, kindly comment recheck in this PR.

@mariobern
Copy link
Contributor Author

recheck

@mariobern
Copy link
Contributor Author

@ayo-klaytn hi Ayo, seems like recheck isn't working

@ayo-klaytn
Copy link
Collaborator

Hi @mariobern

Kindly comment: I have read the CLA Document and I hereby sign the CLA in this PR.
Then comment : recheck afterwards.

You can use this PR for reference

@mariobern
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@mariobern
Copy link
Contributor Author

recheck

@mariobern
Copy link
Contributor Author

much appreciated @ayo-klaytn for the help!

@mariobern
Copy link
Contributor Author

still missing the banner but everything else is good

@mariobern
Copy link
Contributor Author

@ayo-klaytn hi I'm trying to find the folder img/banners but can't seem to find it anywhere in the repo, could you point me to it?

@scott-klaytn
Copy link
Collaborator

@ayo-klaytn hi I'm trying to find the folder img/banners but can't seem to find it anywhere in the repo, could you point me to it?

스크린샷 2024-10-30 오전 8 44 40

@mariobern
Copy link
Contributor Author

@ayo-klaytn @scott-klaytn done, kindly review and let me know if I miss anything

@mariobern
Copy link
Contributor Author

@ayo-klaytn @scott-klaytn thanks for the approvals

what are the next steps to get merged here? let me know if you need anything from my side

@ayo-klaytn ayo-klaytn merged commit 9aec405 into kaiachain:main Oct 31, 2024
1 check passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2024
@ayo-klaytn
Copy link
Collaborator

Hi @mariobern

Just merged the PR. Thanks for your contribution 🫡

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants