New APIs Part 1 #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add Django REST Framework, and the SimpleJWT plugin for REST framework dependencies - Add API authentication middle ware which transparently checks API keys and sets `request.user`. Remote API views no longer have to independently authenticate each access. - Add v3 URLs - Add AuthenticationRequiredMixin for restricting access to authenticated APIs - Refactor Remote Views
- Shifts calculation now returns IntegerField - Refactored `make_table` function and moved it to mxlive.utils instead of duplicating code in `schedule.stats`
- Add False parameter to ipaddress.ip_network calls in middleware.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several significant changes to focusing on refactoring middleware, updating URL patterns, and improving authentication mechanisms for API calls. The most significant changes involve updating middleware to derive from
MiddlewareMixin, and refactoring URL patterns to usepathinstead ofre_path.Middleware Refactoring:
PermissionsMiddleware,TrustedAccessMiddleware, and other middleware classes to inherit fromMiddlewareMixinfor better compatibility with Django's middleware system. [1] [2]APIAuthenticationMiddlewarefor handling API authentication using JWT tokens.URL Patterns Update:
mxlive/remote/urls.pyto usepathinstead ofre_pathand added JWT authentication views.mxlive/remote/urls_v2.pyto separate versioned API endpoints.Authentication Improvements:
VerificationMixinwithAuthenticationRequiredMixinin view classes to ensure that only authenticated users can access certain endpoints without requiring URL signatures. [1] [2] [3]get_v2_userandget_v3_userto handle user authentication for different API versions.Code Cleanup:
make_tablefunction frommxlive/lims/stats.pyand replaced it with an import frommxlive.utils.stats.View Enhancements:
request.userdirectly instead of fetching the user from URL parameters, aligning with the new authentication approach. [1] [2] [3]