-
-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node space now required before children block #495
Comments
I... don't like that this is required now and I kinda feel like it's an accident |
I didn't mean to come off very opinionated with "blessing in disguise", I'm fine either way. |
do you think it should be required? I feel like tightly-packed kdl like this should be legal, if only for practical purposes of data transfer: |
That seems fine to me. One thing I wonder about is the interaction with slashdash comments:
So, |
no worries. I think this is a minor thing that we can justify slapping on as a patch. I'm seeing the RFC process as another opportunity to iron out things we've been discovering since the initial 2.0.0 release, too. THAT is gonna have to be seriously solid, but it's going to be a long process. |
and yes, I like your suggested edit to the grammar. I think we should do it, tbh. I'd love to hear from others, though. |
No real opinion, fwiw. As long as it's unambiguous I'm fine with compact parsing. |
Let's get a PR, then? :) |
Between v1 and v2, the grammar changed, requiring
node-space
beforenode-children
:What I don't remember, was this change intentional (I don't see it in the changelog), or was it not? If not, is it a blessing in disguise or should we revert?
The text was updated successfully, but these errors were encountered: