Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix System tests #531

Closed
pdyraga opened this issue Feb 13, 2023 · 3 comments
Closed

Fix System tests #531

pdyraga opened this issue Feb 13, 2023 · 3 comments
Assignees

Comments

@pdyraga
Copy link
Member

pdyraga commented Feb 13, 2023

For the last 5 days System Tests keep failing. All failure reasons are mostly about the infrastructure or timing issues.

We need to stabilize them.

2023-02-13
https://github.com/keep-network/tbtc-v2/actions/runs/4158928738/jobs/7194500178
Failed in system-tests-deposit-redemption in "Install Solidity dependencies" step with:

mv: cannot stat '/home/runner/work/tbtc-v2/tbtc-v2/solidity/external/npm/@keep-network/keep-core/artifacts/TokenStaking.json': No such file or directory

2023-02-12
https://github.com/keep-network/tbtc-v2/actions/runs/4153790155/jobs/7185650740
Failed in system-tests-deposit-redemption in "Install Solidity dependencies" step with:

cp: cannot create regular file '/home/runner/work/tbtc-v2/tbtc-v2/solidity/external/npm/@keep-network/keep-core/artifacts/TestModUtils.json': File exists

2023-02-11
https://github.com/keep-network/tbtc-v2/actions/runs/4148695125/jobs/7176940147
Failed in system-tests-deposit-redemption in "Install Solidity dependencies" step with:

cp: cannot create regular file '/home/runner/work/tbtc-v2/tbtc-v2/solidity/external/npm/@keep-network/keep-core/artifacts/BeaconBackportRewards.json': File exists

2023-02-10
https://github.com/keep-network/tbtc-v2/actions/runs/4139583744/jobs/7157317324
Failed in system-tests-deposit-redemption

  1. System Test - Deposit and redemption
    when deposit is made and revealed
    when deposit is swept and sweep proof submitted
    "before all" hook: sweep the deposit and submit sweep proof for "should broadcast the sweep transaction on the Bitcoin network":
    Error: Electrum action failure: [tx 535f5d2b8acba1b478be80a6ebece6d90542360f5dcd7839a32c3f39935e9c36 not in block at height 2,419,483]

2023-02-08
https://github.com/keep-network/tbtc-v2/actions/runs/4119445814/jobs/7113116145
Failed in system-tests-minting-unminting in "Install Solidity dependencies" step with:

cp: cannot create directory '/home/runner/work/tbtc-v2/tbtc-v2/solidity/external/npm/@keep-network/keep-core/artifacts': File exists

@michalinacienciala
Copy link
Contributor

2023-03-07
https://github.com/keep-network/tbtc-v2/actions/runs/4349250793/jobs/7598698598
Failed in system-tests-minting-unminting in "Run scenario" step with:

Error: Electrum action failure: [daemon error: DaemonError({'message': 'Transaction not found.', 'code': -1})]

This will hopefully be fixed by https://github.com/keep-network/tbtc-v2/pull/541

@michalinacienciala
Copy link
Contributor

2023-03-08
https://github.com/keep-network/tbtc-v2/actions/runs/4359792319/attempts/1
Failed in system-tests-deposit-redemption with:

  1. System Test - Deposit and redemption
    when deposit is made and revealed
    when deposit is swept and sweep proof submitted
    "before all" hook: sweep the deposit and submit sweep proof for "should broadcast the sweep transaction on the Bitcoin network":
    Error: Electrum action failure: [Error: failed to find the transaction block height in script hashes' histories]

and in system-tests-minting-unminting with:

  1. System Test - Minting and unminting
    when minting is initiated by making and revealing a deposit to the TBTCVault
    when deposit is swept and sweep proof submitted
    "before all" hook: sweep the deposit and submit sweep proof for "should broadcast the sweep transaction on the Bitcoin network":
    Error: Electrum action failure: [Error: failed to find the transaction block height in script hashes' histories]

This was after #541 got merged to main.

@michalinacienciala
Copy link
Contributor

The problems with the Electrum action failure were fixed in #606.
The rest of the problems is not related specifically to System Tests and will be tracked from now on in threshold-network/solidity-contracts#142.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants