Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: SNOS dependency customizations create duplicates in crate tree #458

Open
notlesh opened this issue Jan 3, 2025 · 0 comments
Open
Labels
bug Something isn't working

Comments

@notlesh
Copy link
Collaborator

notlesh commented Jan 3, 2025

SNOS has been maintaining several forks of its dependencies for some time now. Many of our changes have been included in upstream, but there remain some minor ones which force us to continue to use our own forks.

This becomes very problematic for projects which use SNOS as a dependency (e.g. the prove_block lib) because it creates duplicated and conflicting dependencies which are difficult to work around, resulting in compile errors like:

note: `blockifier::Foo` and `Foo` have similar names, but are actually distinct types

Upstream PRs

As of now, each of these "customizations" has an upstream PR, listed below. However, these still point to main branches and would need to be backported for immediate relief (TODO).

@notlesh notlesh added the bug Something isn't working label Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant