Another bug wrt sort pre/post scripts with colon together

[rfalke-rtl]

Similar to #307

Sorted input with extra blank lines for clarification:

  "scripts": {
    "test": "echo",
    "test:coverage": "echo",

    "pretest:es-check": "echo",
    "test:es-check": "echo",
    "posttest:es-check": "echo",

    "test:types": "echo"
  },

Output with npx [email protected]:

  "scripts": {
    "pretest:es-check": "echo",
    "test": "echo",
    "test:coverage": "echo",
    "test:es-check": "echo",
    "test:types": "echo",
    "posttest:es-check": "echo"
  }

[keithamus]

PRs welcome!

[rfalke-rtl]

After looking into this further is shows that 2.12.0 works as I would expect it. The change of #330 changed the behavior.

The question is what is the correct/intended behavior. I think the expected order in

{
  "scripts": {
    "prebuild": "run-s prebuild:*",
    "prebuild:1": "node prebuild.js 1",
    "prebuild:2": "node prebuild.js 2",
    "prebuild:3": "node prebuild.js 3",
    "build": "run-s build:*",
    "build:bar": "node bar.js",
    "build:baz": "node baz.js",
    "build:foo": "node foo.js",
    "postbuild": "run-s prebuild:*",
    "postbuild:1": "node prebuild.js 1",
    "postbuild:2": "node prebuild.js 2",
    "postbuild:3": "node prebuild.js 3",
    "d-unrelated": "..",
    "e-unrelated": "..",
    "f-unrelated": "..",
  }
}

is quite special and a generic tool like sort-package-json should support the common case (see my expectations from above) out of the box.

[rfalke-rtl]

Ok than I propose #333 to revert the recent changes.

[keithamus]

@chouchouji thoughts?

[chouchouji]

@chouchouji thoughts?

I check the issue and pr. The result of sorting pre/post scripts you expected is quite different with #307. I am not sure that which is better? Maybe we can take a discussion.