Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong decoding of filter parameters #7307

Closed
MilosPaunovic opened this issue Feb 11, 2025 · 4 comments · Fixed by #7409
Closed

Wrong decoding of filter parameters #7307

MilosPaunovic opened this issue Feb 11, 2025 · 4 comments · Fixed by #7409
Assignees
@aeSouid
Labels
area/frontend Needs frontend code changes bug Something isn't working

Comments

@MilosPaunovic
Copy link
Member

MilosPaunovic commented Feb 11, 2025 •
edited
Loading

There is an issue with decoding new filter parameters from URL and into the KestraFilter component.

On selection, URL is updated properly, but when we reload the page with selected parameters, the comparator value is missing. See video below for more details.

Screencast.from.2025-02-11.13-53-09.webm
@MilosPaunovic MilosPaunovic added area/frontend Needs frontend code changes bug Something isn't working labels Feb 11, 2025
@github-project-automation github-project-automation bot moved this to Backlog in Issues Feb 11, 2025
@aeSouid aeSouid moved this from Backlog to In progress in Issues Feb 13, 2025
@MilosPaunovic MilosPaunovic mentioned this issue Feb 14, 2025
Merged
@MilosPaunovic
Copy link
Member Author

Hey @aeSouid, I've had some work around labels & filters to do, so I noticed the inconsistencies with operator label in filter component, so I've handled it in #7399. Could you double check if that also solves this issue, if so, you can close it.

@aeSouid
Copy link
Contributor

aeSouid commented Feb 14, 2025

@MilosPaunovic nice, i will check

@aeSouid
Copy link
Contributor

aeSouid commented Feb 14, 2025

@MilosPaunovic good it solves the issue, only one is broken for the date

Image

@aeSouid
Copy link
Contributor

aeSouid commented Feb 14, 2025

@MilosPaunovic i will fix it

@aeSouid aeSouid linked a pull request Feb 14, 2025 that will close this issue
fix filter on comparator absolut date #7409
Merged
@github-project-automation github-project-automation bot moved this from In progress to Done in Issues Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aeSouid aeSouid

Labels
area/frontend Needs frontend code changes bug Something isn't working
Projects
Issues
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix filter on comparator absolut date kestra-io/kestra
2 participants
@MilosPaunovic @aeSouid